Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named Mode Args #84 #85

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Named Mode Args #84 #85

merged 1 commit into from
Mar 1, 2018

Conversation

maxiwoj
Copy link
Contributor

@maxiwoj maxiwoj commented Feb 28, 2018 •
edited by afronski
Loading

Added support for specifying mode arguments via flags.

Named Mode Args #84
f0798b2 
Added support for specifying mode arguments via flags
afronski
afronski approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@afronski afronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I will wait for opinion of the rest.

@afronski
Copy link
Contributor

afronski commented Mar 1, 2018

This closes #84.

@afronski afronski merged commit 530dc63 into release_2_0 Mar 1, 2018
@afronski afronski added this to the Cumulus - 2.0 milestone Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfigwer pfigwer pfigwer approved these changes

@afronski afronski afronski approved these changes

@amamla amamla Awaiting requested review from amamla

@jlampar jlampar Awaiting requested review from jlampar

@SylwiaGargula SylwiaGargula Awaiting requested review from SylwiaGargula

Assignees
No one assigned
Labels
documentation help wanted user experience
Projects
None yet
Milestone
Cumulus - 2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maxiwoj @afronski @pfigwer