Unicode improvements #131
Merged
Unicode improvements #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jsone:encode` expects strings as utf-8 encoded binaries. However if printable range is set to latin1 (which is the default; printable range is a global setting and can only be changed at VM start, see `erl +pc`), `io_lib:format` can output characters in the range 128-255. These are valid bytes (so can be converted with `list_to_binary/1`) but invalid utf-8 bytes. Use the `unicode` module instead to convert such characters to multi-byte representation. fixes Appliscale#127
Also when formatting terms and exceptions pretty print characters also above 255 if the VM is started with unicode printable range. (t unicode translation modifier)
Closed
afronski
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #127