Add a ping checker #3 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
checks/ping.go
Outdated
| return &CustomCheck{ | ||
| CheckName: name, | ||
| CheckFunc: func() (details interface{}, err error) { | ||
| pingCtx, _ := context.WithTimeout(context.Background(), timeout) |
There was a problem hiding this comment.
Non-cancelled contexts are the most common forms of memory leaks in go. I would add defer cancel() here.
There was a problem hiding this comment.
I admit, I committed without running the build locally :P
| For example, you can use it as a DB ping check (`sql.DB` implements the Pinger interface): | ||
| ```go | ||
| db, err := sql.Open(...) | ||
| dbCheck, err := checks.NewPingCheck("db.check", db, time.Millisecond*100) |
There was a problem hiding this comment.
I would probably add a checks.Must function here with the func(check Check, err error) signature, so that checks initialized in a main function can panic. I find a commonly applied practice to interrupt application bootstrap and exit with panic if something goes wrong.
Obviously that's optional and could be part of a subsequent PR.
There was a problem hiding this comment.
Makes sense, but I need to read about this pattern. I'm still green in golang ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a ping checker as requested in #3