Change appId key to match the iOS side of the plugin #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the plugin is broken for Flutter iOS apps.
There is a mismatch between the app id passed from Dart side and the one that the iOS side of the plugin tries to look up. On the Dart side, the key for app id is
appId
, while on the iOS side it'safAppId
.This PR changes the key on Dart side to
afAppId
to match what the iOS side is expecting. I also updated the README to have the correct key there as well.To see what's the problem with the current version, see the specific lines here:
https://github.com/AppsFlyerSDK/flutter_appsflyer_sdk/blob/c5e3050057872efe166b3194fe41c72edb7e7568/lib/appsflyer_constants.dart#L3
https://github.com/AppsFlyerSDK/flutter_appsflyer_sdk/blob/c5e3050057872efe166b3194fe41c72edb7e7568/ios/Classes/AppsflyerSdkPlugin.h#L11