Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change appId key to match the iOS side of the plugin #1

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

roughike
Copy link
Contributor

@roughike roughike commented Jan 16, 2019

Currently the plugin is broken for Flutter iOS apps.

There is a mismatch between the app id passed from Dart side and the one that the iOS side of the plugin tries to look up. On the Dart side, the key for app id is appId, while on the iOS side it's afAppId.

This PR changes the key on Dart side to afAppId to match what the iOS side is expecting. I also updated the README to have the correct key there as well.

To see what's the problem with the current version, see the specific lines here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants