Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run apt-get update in CI #275

Merged
merged 1 commit into from
May 18, 2022
Merged

Run apt-get update in CI #275

merged 1 commit into from
May 18, 2022

Conversation

kamilzyla
Copy link
Collaborator

@kamilzyla kamilzyla commented May 18, 2022

Changes

Run apt-get update in CI before installing system dependencies. I have just encountered a situation in a commercial project, where the CI was failing on this step and this change resolved the problem.

How to test

See the CI results on test-ci branch, which contains a freshly initialized Rhino app (using the package version from this PR).

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilzyla kamilzyla merged commit 95b7260 into main May 18, 2022
@kamilzyla kamilzyla deleted the apt-get-update branch May 18, 2022 11:38
@kamilzyla kamilzyla self-assigned this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants