Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a template for .rscignore file. #299

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

jakubnowicki
Copy link
Member

Changes

Closes #280

How to test

  1. Create a Rhino application
  2. Verify if .rscignore file exists in the root directory
  3. Run any command that will create .rhino directory (e.g. rhino::lint_sass())
  4. Try publishing the application in RStudio, using "Publish" button

Copy link
Collaborator

@kamilzyla kamilzyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd suggest to merge #301 first and rebase onto that, so that our CI status stays green.

@jakubnowicki jakubnowicki merged commit 623dd53 into main Jul 6, 2022
@jakubnowicki jakubnowicki deleted the add-rscignore branch July 6, 2022 13:37
@Tom-Jenkins
Copy link

Hi @kamilzyla and @jakubnowicki,

First, I just want to thank you for creating rhino as I've been using it to develop a fairly large project and really like the framework.

I have followed the deployment thread to this PR as I am trying to deploy a prototype to my shinyapps.io account via rsconnect. I have the same error message as you mentioned in #280.

image

Have you found any ways around this?

@Tom-Jenkins
Copy link

Hi @kamilzyla and @jakubnowicki,

First, I just want to thank you for creating rhino as I've been using it to develop a fairly large project and really like the framework.

I have followed the deployment thread to this PR as I am trying to deploy a prototype to my shinyapps.io account via rsconnect. I have the same error message as you mentioned in #280.

image

Have you found any ways around this?

Apologies, I just worked it out – I copied this file from your showcase into my project folder and it worked!

https://github.com/Appsilon/rhino-showcase/blob/main/.rscignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RStudio complains during push-button deployment
3 participants