Support HTML in React context

[jakubsob]

Closes #13

Test app

library(shiny)
library(shiny.react)

shinyApp(
  ui = tagList(
    ReactContext(
      HTML(
        "<div style='font-weight: bold;'>Hello</div>"
      )
    ),
    reactOutput("react_output")
  ),
  server = function(input, output) {
    output$react_output <- renderReact({
      HTML(
        "<div style='font-weight: bold;'>Hello</div>"
      )
    })
  }
)

@kamilzyla Are there more cases which we should support?

[codecov-commenter]

Codecov Report

Merging #66 (a7ae791) into main (6e2e837) will increase coverage by 62.57%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##            main      #66       +/-   ##
==========================================
+ Coverage   9.72%   72.29%   +62.57%     
==========================================
  Files          5        5               
  Lines        144      148        +4     
==========================================
+ Hits          14      107       +93     
+ Misses       130       41       -89     

Files Changed	Coverage Δ
R/reactData.R	52.17% <100.00%> (+45.03%)	⬆️

... and 4 files with indirect coverage changes

[averissimo]

Cool new feature for {shiny.react} 🎸

I have 2 comments on the PR.

1. NAMESPACE is missing the exported function and is not detecting html classes in asReactData method, defaulting to asReactData.default
   • needs devtools::document()
2. The isHTML(str) is too broad and is parsing text that contains a tag in it.
   • The function and call can probably be removed as it works without them
     • 🟡 Unless I'm missing a required feature that will parse any string that contains a html tag

Reproducible example for testing my comments on 2.

pkgload::load_all()
library(shiny)
library(shiny.react)

shinyApp(
  ui = tagList(
    ReactContext(
      HTML(
        "<div style='font-weight: bold;'>Hello <span style='font-weight: normal;'>my friend</span></div>"
      )
    ),
    ReactContext(
      "<div style='font-weight: bold;'>Hello (just plain text)</div>"
    ),
    reactOutput("react_output")
  ),
  server = function(input, output) {
    output$react_output <- renderReact({
      HTML(
        "<div style='font-weight: bold;'>Hello (renderReact)</div>"
      )
    })
  }
)

Screenshot of what I understand to be the expected result

[jakubsob]

Thanks @averissimo, that was great review. I resolved your comments and added a few shinytest2 tests to capture this behavior that is implemented in this PR. PTAL 😉

[averissimo]

LGTM!! 💯

Great that you added the test!

Sorry for the delay, I thought I already approved this ages ago.