Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it not necessary code? #3

Open
two4zero opened this issue Mar 21, 2019 · 1 comment
Open

Is it not necessary code? #3

two4zero opened this issue Mar 21, 2019 · 1 comment
Assignees

Comments

@two4zero
Copy link
Contributor

<select id="attribute_set" <?php if(!empty($productId)){ echo 'disabled'; } ?> name="set" <?php if(!empty($productId)){ echo __('disabled'); } ?>

Is it not necessary code?
<?php if (!empty($productId)) {echo __('disabled');}?>

@sathishkumarContus
Copy link

Hi,
I understand your query. I noticed, two disabled validation are maintaining and it is not require. I will remove the unnecessary code and update it soon.

Reason for validation:
By default in our marketplace, we do not allow seller to change the attribute type and product type for existing products so we have disable the div using css. In case the inline css is not loading properly in fronted, this attributes will be accessible.So, in order to avoid this, we have disabled the field in the code.

Thanks,
Sathishkumar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants