Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLM version of zone averaging missing diagnostics #10

Open
matthipsey opened this issue Jan 31, 2024 · 2 comments
Open

GLM version of zone averaging missing diagnostics #10

matthipsey opened this issue Jan 31, 2024 · 2 comments
Assignees

Comments

@matthipsey
Copy link
Contributor

The copy_to_zone function in GLM does not process diagnostics.

https://github.com/AquaticEcoDynamics/GLM/blob/f83530eaf476c16a34cbd21d827dcd8d6d0de858/src/glm_aed.F90#L1022

This is an issue for simulations with benthic_mode=2 where diagnostics are required to be used in calculations

(Note that the FV-AED version of this function includes cc_diag and works properly.)

@rqthomas
Copy link
Collaborator

rqthomas commented Sep 3, 2024

@matthipsey @casper-boon Has this been addressed in GLM 3.9?

@casper-boon
Copy link
Contributor

casper-boon commented Sep 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants