Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for STI #11

Merged
merged 1 commit into from
May 22, 2016
Merged

add support for STI #11

merged 1 commit into from
May 22, 2016

Conversation

iguto
Copy link
Contributor

@iguto iguto commented May 20, 2016

STI uses type field, however model.to_json does not include type field.
This PR fixes the problem by pasing an option methods: :type to .to_json

STI uses `type` field, however `model.to_json` does not include `type` field.
So, in oder to include `type` field, added `methods: :type` option to `.to_json` called in `ika_export`.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1c15a67 on add_STI_support into 5859fb9 on master.

@iruca3
Copy link
Contributor

iruca3 commented May 22, 2016

Nice fix. Thanks!
I will contain this fix in 1.0.13 release .

@iruca3 iruca3 merged commit 3e48025 into master May 22, 2016
@iruca3 iruca3 deleted the add_STI_support branch May 22, 2016 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants