Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade rails version #13

Merged
merged 1 commit into from
Sep 21, 2017
Merged

upgrade rails version #13

merged 1 commit into from
Sep 21, 2017

Conversation

iruca3
Copy link
Contributor

@iruca3 iruca3 commented Sep 20, 2017

I upgraded rails version.

  • Fixed tests
  • Fixed error on exporting in Rails 5

@iruca3 iruca3 requested review from iguto and 8398a7 September 20, 2017 11:51
iguto
iguto approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@iguto iguto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iruca3 iruca3 merged commit a9e55e9 into master Sep 21, 2017
@iruca3 iruca3 deleted the upgrade_rails branch September 21, 2017 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iguto iguto iguto approved these changes

@8398a7 8398a7 Awaiting requested review from 8398a7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iruca3 @iguto