[spec][platform] Update list_spec.rb #856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[/spec/arachni/platform/list_spec.rb:227]: What was this code intended to accomplish? Signed-off-by: Bryon Gloden, CISSP® <cissp@bryongloden.com>
|
Fixed it, thanks for the heads up, PS. Dev work happens on experimental, not master, for future reference. |
|
No problem. We were hoping the pull request would be merged, and now we know why it was closed. We'll push to the experimental branch going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 label: #defect
Greetings,
Perhaps this code was intended to affect the behavior of the program, but it does not. The expression is useless because it has no side effects and its result is ignored — so we deleted it. Did you intend to make an assertion or assignment?
Signed-off-by: Bryon Gloden, CISSP® cissp@bryongloden.com