fix: add rotations version warning.

ArchiDog1998 · Jun 5, 2024 · 3cd8a87 · 3cd8a87
1 parent d70dced
commit 3cd8a87
Show file tree

Hide file tree

Showing 5 changed files with 467 additions and 433 deletions.
diff --git a/RotationSolver.Basic b/RotationSolver.Basic
diff --git a/RotationSolver/Helpers/RotationHelper.cs b/RotationSolver/Helpers/RotationHelper.cs
@@ -8,12 +8,22 @@ namespace RotationSolver.Helpers;
 internal static class RotationHelper
 {
     private static readonly Dictionary<Assembly, AssemblyInfo> _assemblyInfos = [];
+    private static readonly Dictionary<Assembly, UiString> _assemblyVersionWarnings = [];
 
     public static List<LoadedAssembly> LoadedCustomRotations { get; } = [];
 
     private static readonly Version? RsVersion = GetRSBasicVersion(typeof(RotationHelper).Assembly);
 
-    public static Version? GetRSBasicVersion(Assembly assembly)
+    public static UiString GetWarning(this Assembly assembly)
+    {
+        if (_assemblyVersionWarnings.TryGetValue(assembly, out var info))
+        {
+            return info;
+        }
+        return UiString.None;
+    }
+
+    private static Version? GetRSBasicVersion(Assembly assembly)
     {
         return assembly.GetReferencedAssemblies().Where(n => n.Name == "RotationSolver.Basic").FirstOrDefault()?.Version;
     }
@@ -72,16 +82,29 @@ public static Assembly LoadCustomRotationAssembly(string filePath)
         var version = GetRSBasicVersion(assembly);
         if (version is not null && RsVersion is not null)
         {
-            if(version.Major < RsVersion.Major
+            UiString warning;
+            if (version.Major == RsVersion.Major
+                || version.Minor == RsVersion.Minor
+                || version.Build == RsVersion.Build)
+            {
+                warning = UiString.None;
+            }
+            else if (version.Major < RsVersion.Major
                 || version.Minor < RsVersion.Minor
                 || version.Build < RsVersion.Build)
             {
-                Svc.Log.Error($"The assembly from \"{filePath}\" may be too old, please update it.");
+                warning = UiString.AssemblyLowVersion;
                 if (existingAssembly != null)
                 {
                     return existingAssembly;
                 }
             }
+            else
+            {
+                warning = UiString.AssemblyHighVersion;
+            }
+
+            _assemblyVersionWarnings[assembly] = warning;
         }
 
         var assemblyName = assembly.GetName().Name;

diff --git a/RotationSolver/Localization/Localization.json b/RotationSolver/Localization/Localization.json
@@ -792,5 +792,7 @@
   "RotationSolver.Basic.Data.UiString.ConfigWindow_About_UserCount": "There are {0} RS users among the world!",
   "RotationSolver.Basic.Data.UiString.ThanksForSupporting": "Thank you for supporting!",
   "RotationSolver.Basic.Data.UiString.AutoHealOnTimeline": "Auto heal on timeline",
-  "RotationSolver.Basic.Data.UiString.AutoDefenseOnTimeline": "Auto defense on timeline"
+  "RotationSolver.Basic.Data.UiString.AutoDefenseOnTimeline": "Auto defense on timeline",
+  "RotationSolver.Basic.Data.UiString.AssemblyLowVersion": "This rotation's dependency is too LOW, which may cause some errors. Please update this rotations!",
+  "RotationSolver.Basic.Data.UiString.AssemblyHighVersion": "This rotation's dependency is too HIGH, which may cause some errors. Please update the Rotation Solver!"
 }