Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add Translate FR guide for LADX #2695

Closed
wants to merge 17 commits into from
Closed

Docs: add Translate FR guide for LADX #2695

wants to merge 17 commits into from

Conversation

deoxis9001
Copy link
Contributor

@deoxis9001 deoxis9001 commented Jan 9, 2024 •
edited
Loading

What is this fixing or adding?

Docs: add Translate FR guide for LADX

How was this tested?

If this makes graphical changes, please attach screenshots.

@deoxis9001 deoxis9001 mentioned this pull request Jan 9, 2024
Open
53 tasks
@ScipioWright ScipioWright added the is: documentation Improvements or additions to documentation. label Jan 9, 2024
ReverM
ReverM suggested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ReverM ReverM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plusieurs commentaires ont été fait, les points principaux concerne certains termes qui ne devraient peut-être pas être traduit de l'anglais ou des traductions non uniformes.

worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/ladx/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/ladx/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/ladx/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/ladx/docs/setup_fr.md Show resolved Hide resolved
@deoxis9001 deoxis9001 closed this Jan 13, 2024
@deoxis9001 deoxis9001 deleted the FR-LADX-DOCS branch January 13, 2024 06:54
@deoxis9001 deoxis9001 restored the FR-LADX-DOCS branch January 13, 2024 06:54
@deoxis9001 deoxis9001 reopened this Jan 13, 2024
@PoryGone PoryGone added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 10, 2024
benny-dreamly
benny-dreamly suggested changes Feb 19, 2024
View reviewed changes
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Show resolved Hide resolved
@benny-dreamly
Copy link
Contributor

My review was made with my knowledge of French coming from Canada, so if this France French, I'm not too sure about all of the rules, but I still think there's quite a lot of errors in the translation that could use some fixing.

@github-actions github-actions bot removed the is: documentation Improvements or additions to documentation. label Feb 21, 2024
Loloweb
Loloweb reviewed Feb 22, 2024
View reviewed changes
Copy link

@Loloweb Loloweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proofreading

worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/fr_Links Awakening DX.md Outdated Show resolved Hide resolved
worlds/ladx/docs/setup_fr.md Outdated Show resolved Hide resolved
benny-dreamly
benny-dreamly approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@benny-dreamly benny-dreamly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry about being super picky. I now get the context better.

@alwaysintreble alwaysintreble added is: documentation Improvements or additions to documentation. is: enhancement Issues requesting new features or pull requests implementing new features. labels Mar 28, 2024
@deoxis9001
Copy link
Contributor Author

it's now ready for merge

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 1, 2024
ThePhar
ThePhar requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until a better UX solution is created for displaying setup guides in different languages, I think this should be combined in how it is currently for most other games rather than separate entries.

Example:
image

Rather than:
image

@ThePhar ThePhar added waiting-on: author Issue/PR is waiting for feedback or changes from its author. and removed waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. labels Jun 3, 2024
@deoxis9001
Copy link
Contributor Author

deoxis9001 commented Jul 30, 2024 •
edited
Loading

Until a better UX solution is created for displaying setup guides in different languages, I think this should be combined in how it is currently for most other games rather than separate entries.

Example: image

Rather than: image

On DLCQuest, I was told to follow the example of “Adventure”.

image
it was rever who told me to do it this way

@deoxis9001
Copy link
Contributor Author

I think I'll close this request if I don't get an answer.

@deoxis9001 deoxis9001 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benny-dreamly benny-dreamly benny-dreamly approved these changes

@Loloweb Loloweb Loloweb approved these changes

@ReverM ReverM Awaiting requested review from ReverM

@ThePhar ThePhar Awaiting requested review from ThePhar

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: author Issue/PR is waiting for feedback or changes from its author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@deoxis9001 @benny-dreamly @ThePhar @Loloweb @ReverM @alwaysintreble @ScipioWright @Exempt-Medic @PoryGone