Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible non-unique caching keys for many requests #119

Closed
Archomeda opened this issue May 20, 2022 · 0 comments · Fixed by #121
Closed

Possible non-unique caching keys for many requests #119

Archomeda opened this issue May 20, 2022 · 0 comments · Fixed by #121
Labels
Area: Web API v2 Related to the v2 web API Area: Web cache Related to the web API caching Priority: High High priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working

Comments

@Archomeda
Copy link
Owner

It's possible that the many requests do not have their ids transformed to proper cache id keys. It seems to be missing the call to the GetCacheId method.

Needs investigation.

See https://github.com/Archomeda/Gw2Sharp/blob/master/Gw2Sharp/WebApi/Middleware/CacheMiddleware.cs#L67-L80=
@Archomeda Archomeda added Type: Bug Something isn't working Priority: High High priority Area: Web cache Related to the web API caching Area: Web API v2 Related to the v2 web API labels May 20, 2022
@Archomeda Archomeda mentioned this issue May 22, 2022
Merged
@Archomeda Archomeda added the Resolution: Fixed The issue has been fixed label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Web API v2 Related to the v2 web API Area: Web cache Related to the web API caching Priority: High High priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix many item caching so that individual items have proper cache ids Archomeda/Gw2Sharp
1 participant
@Archomeda