Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check to GuidConverter. #28

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Add null check to GuidConverter. #28

merged 3 commits into from
Jan 23, 2020

Conversation

dlamkins
Copy link
Contributor

Checks if reader TokenType is null. If it is, it returns Guid.Empty, otherwise it returns the Guid.

Fixes #27.

@Archomeda Archomeda added Area: Web API v2 Related to the v2 web API Type: Bug Something isn't working labels Jan 23, 2020
@Archomeda Archomeda merged commit 79a7107 into Archomeda:master Jan 23, 2020
@dlamkins dlamkins deleted the fix/27-guidconverter-needs-null-check branch January 24, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Web API v2 Related to the v2 web API Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GuidConverter needs a null check
2 participants
@dlamkins @Archomeda