Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate performance of deserializing enums #52

Closed
Archomeda opened this issue Mar 22, 2020 · 0 comments · Fixed by #54
Closed

Investigate performance of deserializing enums #52

Archomeda opened this issue Mar 22, 2020 · 0 comments · Fixed by #54
Labels
Area: Web API v2 Related to the v2 web API Resolution: Fixed The issue has been fixed Type: Bug Something isn't working

Comments

@Archomeda
Copy link
Owner

I encountered this while checking if I added support for EnumMemberAttribute.
Apparently every time when an enum needs to be deserialized, it gets all enum names and values, and tries to check if EnumMemberAttribute is defined on any of the values.

I expect this to be pretty taxing because this is all done through reflection.
In order to confirm this, I'll have to run some benchmarks.
@Archomeda Archomeda added the Area: Web API v2 Related to the v2 web API label Mar 22, 2020
This was referenced Mar 22, 2020
Merged
Merged
@Archomeda Archomeda added the Type: Bug Something isn't working label Mar 23, 2020
@Archomeda Archomeda added the Resolution: Fixed The issue has been fixed label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Web API v2 Related to the v2 web API Resolution: Fixed The issue has been fixed Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve enum deserialization performance Archomeda/Gw2Sharp
1 participant
@Archomeda