Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce latest MumbleLink changes #58

Closed
dlamkins opened this issue Apr 28, 2020 · 0 comments · Fixed by #59
Closed

Introduce latest MumbleLink changes #58

dlamkins opened this issue Apr 28, 2020 · 0 comments · Fixed by #59
Labels
Area: Mumble Link Related to the Mumble Link API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Feature An addition to the project

Comments

@dlamkins
Copy link
Contributor

Jonagar has exposed additional details to the MumbleLink API:

  • uint processId
  • byte mountIndex
  • IsInCombat flag (bit 7) to the uiState

A way to set the name of the MumbleLink target has also been provided: -mumble <name> which means that when creating a new mumblelink client within Gw2Sharp it will require the name of the target we wish to connect to.

Mount index matches the enum:

enum MountType : byte
{
    None,
    Jackal,
    Griffon,
    Springer,
    Skimmer,
    Raptor,
    RollerBeetle,
    Warclaw,
    Dragon,
};

REF: https://discordapp.com/channels/384735285197537290/694129718689005619/704727573112029264
@Archomeda Archomeda added Area: Mumble Link Related to the Mumble Link API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Status: In progress This is being worked on Type: Feature An addition to the project labels Apr 28, 2020
@Archomeda Archomeda mentioned this issue Apr 28, 2020
Merged
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed Status: In progress This is being worked on labels Apr 28, 2020
@dlamkins dlamkins mentioned this issue Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Mumble Link Related to the Mumble Link API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Feature An addition to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Mumble Link with new fields and add support for custom names Archomeda/Gw2Sharp
2 participants
@Archomeda @dlamkins