Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly formatted access tokens may cause a FormatException #62

Closed
Archomeda opened this issue Jun 9, 2020 · 0 comments
Closed
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working

Comments

@Archomeda
Copy link
Owner

Archomeda commented Jun 9, 2020

Whenever the access token is invalid according to (some) specifications, performing a request can throw a FormatException. An example is including a single " character.

Failing early is the best solution, so the consumer immediately knows that there's something wrong, instead of finding that out upon the request.
In this case, a pre-validation check in Connection object on the AccessToken property can be added. It will have to check if the token is properly formatted (e.g. does not contain invalid characters).

@Archomeda Archomeda added Type: Bug Something isn't working good first issue Good for newcomers Priority: Medium Medium priority Duration: Short Less than 2 hours of estimated work Area: Web API v2 Related to the v2 web API labels Jun 9, 2020
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed good first issue Good for newcomers labels Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant