Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an exception for hitting the rate limit #8

Closed
Sejsel opened this issue Aug 9, 2019 · 1 comment
Closed

Add an exception for hitting the rate limit #8

Sejsel opened this issue Aug 9, 2019 · 1 comment
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working

Comments

@Sejsel
Copy link

Sejsel commented Aug 9, 2019

Currently, when the rate limit is hit, an UnexpectedStatusException with the message of {"text":"too many requests"} is thrown. The response has a status code of HttpStatusCode.TooManyRequests = 429.

Having something like a TooManyRequestsException would be nice to handle this without having to check the details of the exception.
@Archomeda
Copy link
Owner

Good catch. That's certainly a thing that should be added!

@Archomeda Archomeda added Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Status: Ready Work is accepted and is planned for a future release Type: Bug Something isn't working labels Aug 9, 2019
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed Status: Ready Work is accepted and is planned for a future release labels Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sejsel @Archomeda