Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Soundbound Icon #1819

Merged
merged 5 commits into from
Nov 25, 2023
Merged

Add Soundbound Icon #1819

merged 5 commits into from
Nov 25, 2023

Conversation

Subroutine7901
Copy link
Contributor

Just adds an icon for the app Soundbound (in.shabinder.soundbound).

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 20, 2023

Hi, you also need to add some lines of code to the appfilter.xml file, otherwise it won't get applied.
You can gather it with icon request: https://play.google.com/store/apps/details?id=de.kaiserdragon.iconrequest

@Donnnno Donnnno added the needs more info needs more info label Nov 20, 2023
@TotallyAvailable
Copy link
Contributor

Of course also available on GitHub directly and F-Droid I think.

If you already use something like AppManager you can easily get the information there.
If you have access to the AndroidManifest.xml you'll find it there as well.

@Subroutine7901
Copy link
Contributor Author

Subroutine7901 commented Nov 21, 2023

Ok so here's the code, I'm just putting this here so I don't forget or lose it:

<appfilter>
<!--  Soundbound  -->
<item component="ComponentInfo{in.shabinder.soundbound/in.shabinder.soundbound.MainActivity}" drawable="soundbound"/>
</appfilter>

Otherwise, a quick rundown of what I need to do with the modified appfilter.xml, and the required edits to it would be appreciated.

@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Nov 21, 2023

Drop the top and bottom "appfilter' lines in your quote and just add the middle 2 lines into the appfilter.xml.
(In the same fork you used to push the icon in this PR. It'll automatically be pushed into this request*, keep that in mind. Feel free to test it on a fresh Fork and look at what your Commit changed beforehand, if you want to get a feel for how it works. Alternatively just do the obvious thing the 'Preview' button is there for, which I totally came back for after totally not forgetting to mention it... hopefully ending the editing madness on this comment.)

Doesn't really matter if you put it on top, bottom or follow the alphabetical** order.
As long as the "drawable" = name of the svg and no App update that changes the activity name before the next release, everything else will be taken care of automatically.

Should something else need attention, you'll obviously be informed here, like slight tweaks on the svg or a potential issue with the component info provided.

In case you end up deciding to add further icons, make sure to keep both drawable and svg name the same, connecting possible multi_word_names only with "_".
The way of adding the required entries to the appfilter obviously remains the same.

If nothing else feels wrong after you are done, its down to patience.

As comparison the 'Files changed' tab of this PR should look something like this when you are done.
3584131

*(Can differ depending on how things are done of course)
**(Should the entry end up being added from the actual device that you use Arcticons on, the alphabetical order method may or may not present a bit of a challenge)

Added info to appfilter.xml
@Subroutine7901
Copy link
Contributor Author

Ok, I think that's it.

Added myself to the contributors list, I also plan to make more icons in the future!
@Donnnno
Copy link
Collaborator

Donnnno commented Nov 25, 2023

Fantastic, thank you, and @TotallyAvailable for helping out :)

Co-Authored-By: Subroutine7901 <wchampton999@gmail.com>
@Donnnno Donnnno merged commit ec6b633 into Arcticons-Team:main Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info needs more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants