Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct expiration estimate for musig transactions #232

Merged
merged 2 commits into from
Nov 9, 2022
Merged

fix: correct expiration estimate for musig transactions #232

merged 2 commits into from
Nov 9, 2022

Conversation

ItsANameToo
Copy link
Contributor

@ItsANameToo ItsANameToo commented Nov 8, 2022 •
edited by goga-m
Loading

Summary

https://app.clickup.com/t/3225caf

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel
Copy link

vercel bot commented Nov 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
arkvault ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 1:22PM (UTC)

@github-actions github-actions bot added the bugfix label Nov 8, 2022
@goga-m goga-m force-pushed the fix/musig-expiration-transfers branch from f5cef8d to a9e1aa6 Compare November 8, 2022 13:13
@goga-m goga-m changed the title fix: let SDK set the proper transaction expiration fix: correct expiration estimate for musig transactions Nov 8, 2022
@ItsANameToo ItsANameToo merged commit 49c8b58 into develop Nov 9, 2022
@ItsANameToo ItsANameToo deleted the fix/musig-expiration-transfers branch November 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@dated dated Awaiting requested review from dated

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItsANameToo @goga-m