Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adjustments in exchange form UI #394

Merged
merged 6 commits into from
May 30, 2023
Merged

refactor: adjustments in exchange form UI #394

merged 6 commits into from
May 30, 2023

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented May 29, 2023

Summary

Closes https://app.clickup.com/t/861mvatnp

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel
Copy link

vercel bot commented May 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 9:52am

@goga-m goga-m marked this pull request as ready for review May 29, 2023 05:13
samharperpittam
samharperpittam requested changes May 30, 2023
View reviewed changes
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue seems to be exclusive to Safari and is sadly not fixed in this PR.

Firefox, Chrome and Edge all seem fine.

@goga-m goga-m changed the title refactor: show exchange asset icons in mobile refactor: adjust exchanges icons in mobile May 30, 2023
@goga-m goga-m changed the title refactor: adjust exchanges icons in mobile refactor: adjustments in exchange form UI May 30, 2023
@goga-m
Copy link
Contributor Author

goga-m commented May 30, 2023 •
edited
Loading

@samharperpittam should be fixed now

@goga-m goga-m merged commit b77ddaa into develop May 30, 2023
@goga-m goga-m deleted the refactor/show-exchange-asset-logos branch May 30, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@dated dated Awaiting requested review from dated

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goga-m @samharperpittam