Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operatingSystems.linux = false, still downloads linux drivers #12

Closed
SiKing opened this issue Apr 3, 2014 · 7 comments
Closed

operatingSystems.linux = false, still downloads linux drivers #12

SiKing opened this issue Apr 3, 2014 · 7 comments
Labels

Comments

@SiKing
Copy link

SiKing commented Apr 3, 2014

I am using version 1.0.0. I have:
<operatingSystems>
<windows>true</windows>
<linux>false</linux>
<osx>false</osx>
</operatingSystems>
Just tried this on my Linux machine, and it downloads the Linux binaries!?!?

Further, it errors with: ".bz2 is an unsupported archive type"

Am I doing this wrong?

@Ardesco
Copy link
Owner

Ardesco commented Apr 3, 2014

.bz2 support was added in 1.0.1 (released last night).

The OS thing looks like a bug that i'll look into today.

@SiKing
Copy link
Author

SiKing commented Apr 3, 2014

Definitely broken. Back on my Windows box I tried windows=false and
osx=true, and it still downloads the Windows binaries.

Tried it also with version 1.0.1 - that just errors with nullpointer
exception. :(

On 3 April 2014 00:39, Mark Collin notifications@github.com wrote:

.bz2 support was added in 1.0.1 (released last night).

The OS thing looks like a bug that i'll look into today.

Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-39421158
.

@Ardesco
Copy link
Owner

Ardesco commented Apr 21, 2014

Sorry for the delay, I've just got time to look at this.

I can't reproduce this locally, do you have:

<onlyGetDriversForHostOperatingSystem>false</onlyGetDriversForHostOperatingSystem>

set? If not the above will default to true and it will only try to download drivers for the current OS. I'd like to see a log showing the null pointer error, I'm not sure where that is coming from.

@SiKing
Copy link
Author

SiKing commented Apr 21, 2014

No rush, I understand you are doing this in your spare time. :)

I do not have the onlyGetDriversForHostOperatingSystem declared. My entire pom is at https://svn.code.sf.net/p/genieos/code-0/trunk/demos/pom.xml

For the nullpointer I opened a separate ticket: issue #13.

@Ardesco
Copy link
Owner

Ardesco commented Apr 21, 2014

if <onlyGetDriversForHostOperatingSystem> isn't specified it defaults to true. So if you run this on your Linux machine it will only download the Linux binaries. I've added some logging to make this clearer on the console.

Looks like this is working as specified.

@Ardesco Ardesco closed this as completed Apr 21, 2014
@Ardesco
Copy link
Owner

Ardesco commented Apr 21, 2014

This was missing from the (very basic) documentation in readme.md. It's now been added in.

@SiKing
Copy link
Author

SiKing commented Apr 21, 2014

Works great! :)

On 21 April 2014 07:39, Mark Collin notifications@github.com wrote:

This was missing from the (very basic) documentation in readme.md. It's
now been added in.

Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-40940067
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants