Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: minor GUI and assistant setup enhanecments #1288

Merged
merged 4 commits into from Dec 22, 2023

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Dec 21, 2023

This PR includes 3 enhancements and 1 bug fix:

Chat window improvements:

  1. Reply window colours are fixed on Windows (user input now correctly appears in red so it can be more easily distinguished from the replies)
  2. Blank text is no longer sent to the assistant in cases where the audio-to-text fails or the user simply presses the Send button with no text in the input box

Assistant setup script improvements

  1. The assistant setup script re-uses previously uploaded files instead of creating duplicates. This behaviour can be overridden with the "--upgrade" argument
  2. an assistant_file_checker.py script helps find and delete files that were uploaded to OpenAI but never associated with any Assistant. So far we haven't found any particular problem with having these unused files hanging around but there are known issues with assistants occasionally not being able to find files... perhaps keeping the upload area orderly will help somehow.

These changes have all been tested on Windows and Ubuntu and it seems to be working OK.

BTW, I initially had a cool "listen" feature for the audio-to-text conversion but I wasn't able to get it reliable enough so I'll push that off to a future PR

This helps find files that are not used by any assistant so that they can be deleted
also fix background colour on windows
Also minor stutus text fixes
@rmackay9 rmackay9 changed the title Chat: record button constantly listens Chat: minor GUI and assistant setup enhanecments Dec 21, 2023
@rmackay9
Copy link
Contributor Author

It's a bit long but here's a little interaction from testing on Windows. They key points are that the area around the buttons is the correct colour now. The user's input appears in red and there are more status updates appearing in the bottom left of the window.
image

@peterbarker peterbarker merged commit 429730f into ArduPilot:master Dec 22, 2023
1 check passed
@rmackay9 rmackay9 deleted the chat-listen branch December 22, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants