ExtLibs: setMountConfigure uses mav-cmd-do-mount-configure #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the SetMountConfigure method so that it uses the MAV_CMD_DO_MOUNT_CONFIGURE mavlink command instead of the deprecated ardupilot specific MOUNT_CONFIGURE message.
This method is only used by the Payload Control tab's "Reset Position" button.
By the way, ArduPilot has consumed the do-mount-configure command since before ver 4.0 (I didn't look back any further than this). Ardupilot stopped consuming the roll_stab, pitch_stab and yaw_stab values in version 4.3 but this PR doesn't change how these fields are set anyway.
This has been lightly tested on a real autopilot using a Xacti gimbal. The only difference in behaviour noted was that the flight code no longer displays the deprecated message. Below are before and after screen shots taken during testing.
