GCSViews: ConfigRawParams: look up param type for bitmask helper #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the bitmask helper assumes int32, this means the sign bit in smaller masks cannot be set.
INS_HNTCH_HMNCSis a example of aint8param.Currently the 8th bit will set the value to 128:
This is out of range for a int8, so when you write and read back you get a constrained down value of 127 which is a completely different bitmask.
With this patch when setting the 8th bit:
We now get -128 which is the correct in range value for the int8 param type.