Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Proximity: add parameter to allow user to specify maximum reliable distance #13612

Closed
rmackay9 opened this issue Feb 19, 2020 · 2 comments
Closed

AP_Proximity: add parameter to allow user to specify maximum reliable distance #13612

rmackay9 opened this issue Feb 19, 2020 · 2 comments
Labels
Enhancement Library

Comments

@rmackay9
Copy link
Contributor

Unlike the rangefinder library, the proximity library does not have a user configurable maximum distance. We should add parameters for minimum and maximum reliable distances.

Here are some options for the names of these new parameters:

  • PRX_DIST_MAX, PRX_DIST_MIN (this is probably my favourite, these distances would be in meters)
  • PRX_MAX, PRX_MIN
  • PRX_MAX_CM, PRX_MIN_CM (consistent with AP_RangeFinder's parameter names)
@amilcarlucas
Copy link
Contributor

I vote for the first

@andresrcdev andresrcdev mentioned this issue Jun 19, 2020
Closed
@IamPete1
Copy link
Member

closing in favor of #6583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmackay9 @amilcarlucas @IamPete1