Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: If unable to read the airspeed sensor do not use the value #3188

Closed
WickedShell opened this issue Nov 16, 2015 · 5 comments
Closed

Plane: If unable to read the airspeed sensor do not use the value #3188

WickedShell opened this issue Nov 16, 2015 · 5 comments
Labels

Comments

@WickedShell
Copy link
Contributor

If the digital airspeed sensor can't be read for some reason for more then say 5 attempts? Then we should stop using the reported airspeed data.

@magicrub
Copy link
Contributor

If you mean it should revert back to internal airspeed value on data that is bad then this is a duplicate of #1628

I guess there's two questions: data that is "bad" (ie, blocked tube) vs data that is stale due to comms/hardware problem.

Do those deserve separate issues?

@WickedShell
Copy link
Contributor Author

I had missed the other issue. I'm specifically thinking about a hardware problem here. I'm not sure if thats worth a seperate issue. It should be much easier however, simply ensure that the health bit is being set correctly, and if it's bad, then revert to the internal estimate.

If we want to track that on the other issue then we should just close this.

@magicrub
Copy link
Contributor

The trick is we can switch between, but we can't observe both at the same time. That's what's holding up the fix. no way to sanity check each other's sources.

@WickedShell
Copy link
Contributor Author

Right, this one doesn't need them to be both observed, this would simply be a swap when the hardware is not responding.

@magicrub
Copy link
Contributor

But the problem is you switch forever. If it's a temporary glitch then
you'll want the ability to switch back to the more accurate external
sensor. That said, right now it just lies to you and you crash because we
have no other sanity checking going on.

On Mon, Nov 16, 2015 at 2:14 PM, WickedShell notifications@github.com
wrote:

Right, this one doesn't need them to be both observed, this would simply
be a swap when the hardware is not responding.


Reply to this email directly or view it on GitHub
#3188 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants