Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: remove battery failsafe exeption for Auto mode #7581

Closed
rmackay9 opened this issue Jan 22, 2018 · 2 comments
Closed

Copter: remove battery failsafe exeption for Auto mode #7581

rmackay9 opened this issue Jan 22, 2018 · 2 comments
Assignees

Comments

@rmackay9
Copy link
Contributor

Copter's battery failsafe feature has an exception for Auto mode. Even if the user has set the FS_BATT_ENABLE parameter to "Land", if the vehicle is in Auto, it will always RTL.

https://github.com/ArduPilot/ardupilot/blob/master/ArduCopter/events.cpp#L65

I can't imagine why this exception is required. I think it's more likely that a user would be confused why the vehicle does not do what it has apparently been configured to do.

I suspect this exception is a relic from a time when Copter's failsafe response could not be configured for each failsafe types (i.e. rc/transmitter and battery failsafes responses were combined in a single parameter). Certainly for the RC/Transmitter failsafe we need special handling while in Auto mode because users sometimes want to configure the vehicle to continue with the mission because they plan for it to fly outside of RC/transmitter range. This is not the case for the battery failsafe however.

@Pedals2Paddles
Copy link
Contributor

I saw this a few weeks ago working on the bitmask options and was a little perplexed by it. I can see wanting it to RTL if it's off on a mission. But it does indeed do something that isn't what the operator selected as an option, and isn't published or expected

@rmackay9
Copy link
Contributor Author

rmackay9 commented Feb 5, 2018

Fixed in master and wil go out with Copter-3.6

@rmackay9 rmackay9 closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants