Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChibiOS generator should reject overlapping definitions #9454

Open
WickedShell opened this issue Sep 20, 2018 · 0 comments
Open

ChibiOS generator should reject overlapping definitions #9454

WickedShell opened this issue Sep 20, 2018 · 0 comments
Labels

Comments

@WickedShell
Copy link
Contributor

Bug report

Issue details

It's possible to define multiple pins to the same define, which is silently accepted by the generator. This should be caught as a fatal build error when processing the hwdef.dat. For example the following will currently generate without any issues, even though there is a duplicate definition for AUX_ADC2:

--- a/libraries/AP_HAL_ChibiOS/hwdef/fmuv3/hwdef.dat
+++ b/libraries/AP_HAL_ChibiOS/hwdef/fmuv3/hwdef.dat
@@ -279,7 +279,7 @@ PC1 MAG_CS CS
 PC2 MPU_CS CS
 
 # This defines more ADC inputs.
-PC3 AUX_POWER ADC1 SCALE(1)
+PC3 AUX_ADC2 ADC1 SCALE(1)
 PC4 AUX_ADC2 ADC1 SCALE(1)
 
 # And the analog input for airspeed (rarely used these days).

Version
7fda309

Platform
[ x ] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant