Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDS use black format #25597

Merged
merged 3 commits into from Nov 22, 2023
Merged

DDS use black format #25597

merged 3 commits into from Nov 22, 2023

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 22, 2023

Purpose

Switch to black for formatting. I broke the automatic format into a single commit. After this PR, the colcon tests pass locally for all the ROS 2 stuff in ArduPilot.

Testing

colcon build --packages-up-to ardupilot_dds_tests
colcon test --packages-up-to ardupilot_dds_tests


colcon test-result --all

OR

colcon test --packages-up-to ardupilot_dds_tests --event-handlers=console_cohesion+
Label Time Summary:
black         =   0.22 sec*proc (1 test)
copyright     =   0.23 sec*proc (1 test)
lint_cmake    =   0.08 sec*proc (1 test)
linter        =   0.90 sec*proc (5 tests)
pep257        =   0.12 sec*proc (1 test)
xmllint       =   0.25 sec*proc (1 test)

Total Test time (real) =   0.90 sec
---
Finished <<< ardupilot_sitl [0.97s]

Known issues

* This commit is files changed automatically by the black linter

Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* Removed dependency on ament_lint_common
* Removed all flake8 artifacts
* Ordered linters alphabetically

Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Copy link
Contributor

@srmainwaring srmainwaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting changes look good, they are all to adjust the line length to the back 88 char default (IIRC the previous formatting used an override to set the max line length to 80 char to be consistent with flake8).

Copy link
Contributor

@srmainwaring srmainwaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm tests complete with no errors on Ubuntu 22.04 VM.

@magicrub magicrub merged commit 61e2c5f into ArduPilot:master Nov 22, 2023
86 checks passed
@Ryanf55 Ryanf55 deleted the dds-use-black-format branch November 22, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants