Always depart loiter WP towards next WP #3694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- LOITER_UNLIM does not have it because it never ends
|
The bool flag is 1 for checking for heading, so you must enable it via param. I'm wondering if we should invert that so you have to set the flag to ignore heading and by default (0) it checks the heading. |
|
I'm in favor of the heading alignment being default behavior as I feel this is what most operators would expect. |
|
I've removed the bool flag and now this behavior will be default so no GCS change is needed |
|
merged be3941e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only helpful for plane but available for all. When exiting a liter_turns, loiter_alt, or loiter_time there is now an optional cmd param field of heading required where when set to 1 yo must be +/- 10deg of the next waypoint before you are allowed to exit the loiter.
There needs to be a GCS change to added the bool label field 3 for loiter time/turns.
This fixes #1906