Dev: Add param conversion removal process #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKear
commented
Aug 16, 2021
|
@Hwurzburg When do we do the wiki Dev call? Is it done as part of the regular dev call or is there a seperate call specificially for the wiki? |
|
Regular devcall |
peterbarker
reviewed
Aug 23, 2021
tridge
requested changes
Aug 23, 2021
|
@Gone4Dirt still awaiting requested changes |
MattKear
force-pushed
the
pr_add_param_process
branch
from
b9690c0
to
71d7e67
Compare
|
Changes made and rebased. |
|
@tridge Approval?? |
tridge
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some details around a new process to be implimented when adding parameter conversions. It also updates the steps to perform a parameter conversion.
The process is simple: add a standard expression: PARAMETER_CONVERSION that we can grep for. And detail the date and version when the conversion can be removed. This is based on what has been disscussed on Discord and the dev call. Happy to modify the process as maintainers think is appropriate.
Once, we are happy with the process, I am happy to go on a hunt to find the already added conversions to add the comments appropriatley.