add ros2-cartographer-slam page #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-fuoco
force-pushed
the
add-ros2-cartographer
branch
from
0779087
to
6399b14
Compare
pedro-fuoco
force-pushed
the
add-ros2-cartographer
branch
from
6399b14
to
bd87209
Compare
pedro-fuoco
force-pushed
the
add-ros2-cartographer
branch
from
bd87209
to
bc98fd2
Compare
|
thanks |
|
@tridge also asked me to link the common-ekf-sources page ArduPilot/ardupilot_ros#12 (comment) I will submit a fixup |
pedro-fuoco
force-pushed
the
add-ros2-cartographer
branch
from
bc98fd2
to
5144744
Compare
|
@Hwurzburg Done! Let me know if I need to change anything else, thanks for the review |
|
Question, how would you use this on a real vehicle per the warning? via companion computer? |
Yes, but the tutorials on how to setup ardupilot and ROS 2 with a companion computer are still not available. I suggest leaving the warning there preemptively since it is a safety measure. @Hwurzburg |
pedro-fuoco
force-pushed
the
add-ros2-cartographer
branch
from
5144744
to
8f3fba5
Compare
|
Removed the warning about rosdep since it is now supported ArduPilot/ardupilot_ros@ca804c8 |
|
LGTM...merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5359.
The technical details have been heavily based on the
ardupilot_rosREADME, which is linked in the page@Hwurzburg could you upload the video to Ardupilot's youtube channel ?