Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.xml: add a command to deal with safety switch #352

Merged

Conversation

peterbarker
Copy link

decoding the old MODE message is a terrible way to do this

@peterbarker
Copy link
Author

I've created a PR against mavlink/master here: mavlink#2081 . We should probably keep discussions on that PR instead of this one.

@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_SAFETY_SWITCH_STATE branch from 43f8f5d to a696a8f Compare February 17, 2024 00:19
<param index="1" label="Desired State" enum="SAFETY_SWITCH_STATE">New safety switch state.</param>
<param index="2">Empty.</param>
<param index="3">Empty.</param>
<param index="4">Empty</param>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to . or not to ., that is the question...

@tridge
Copy link
Collaborator

tridge commented Feb 19, 2024

looks good to me

decoding the old MODE message is a terrible way to do this
@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_SAFETY_SWITCH_STATE branch from a696a8f to 7257b3c Compare February 22, 2024 06:16
@tridge tridge merged commit 76a2c50 into ArduPilot:master Feb 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants