Add SI units #39
Merged
Add SI units #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
amilcarlucas
force-pushed
the
add_SI_units
branch
from
04b029f
to
0c01192
Compare
|
seems reasonable to me. I guess adding the "units" field doesn't affect the compatibility of the message between clients? I know that changing the field names affects compatibility between systems but I assume/hope this isn't the case for the new "units" metadata. |
…he other xml files This allows using simple text based diff tools and enforces order
…o message fields This allows GCS software to not hardcode/guess the units, and instead use the explicit defined units.
amilcarlucas
force-pushed
the
add_SI_units
branch
from
0c01192
to
b2bdf3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for GCS to have hardcoded unit information