Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSTACLE_DISTANCE: add higher angle resolution and angle offset #95

Merged
merged 1 commit into from
May 29, 2019
Merged

OBSTACLE_DISTANCE: add higher angle resolution and angle offset #95

merged 1 commit into from
May 29, 2019

Conversation

magicrub
Copy link

This MAVLink v2 packet allows for flexible obstacle detection from multiple sensors of varying resolution while still being backwards compatible.

increment_f (to override increment):
When forced to send exactly 72 samples, having an integer spacing just didn't make sense. Needed to be float so that the correct angular range was understood

angle_offset:
Same as, and adds to, param "PRX_YAW_CORR". However, if you have two sensors you can send multiple messages covering different areas (at varying resolutions). For example, a 360 degree spinning lidar + long-range forward radar/lidar + wide angle sonar(s). With multiple messages, we can aggregate a better picture and down-scale the resolution to whatever the flight controller can handle in that version. And that will improve as we get fancier flight controllers with more memory Meanwhile, the data is no longer limited by the comms link, just on how to store it once received.

count:
Allow the option to send less than 72 distance values.

Copy link
Member

@OXINARF OXINARF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change to common so it needs to be discussed upstream.

I'm completely in favor of angle_offset, I have my doubts about the real-life usefulness of increment_f, but if you are putting it to use then I'm wrong 🙂

message_definitions/v1.0/common.xml Outdated Show resolved Hide resolved
message_definitions/v1.0/common.xml Outdated Show resolved Hide resolved
@magicrub
Copy link
Author

I have my doubts about the real-life usefulness of increment_f

Very important. @rmackay9 and @jmachuca77 really want it too. The issue is if you have 72 samples with integer degree, what happens if those 72 samples cover 90 degrees? Or 20 degrees? This is to prepare the Proximity library for higher resolution target tracking which is being worked on now..

@magicrub
Copy link
Author

Here's the upstream PR mavlink#1142

@magicrub
Copy link
Author

This has been merged into upstream. I've replaced the commit on this PR branch to be a cherry-pick from upstream. I'll merge this once it passes travis.

@magicrub magicrub dismissed OXINARF’s stale review May 29, 2019 17:16

merged in upstream

@magicrub magicrub merged commit 3198f78 into ArduPilot:master May 29, 2019
@magicrub magicrub deleted the object_angle_float branch May 29, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants