Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magfit_WMM: support new compass param naming #608

Merged
merged 1 commit into from
Jan 3, 2022
Merged

magfit_WMM: support new compass param naming #608

merged 1 commit into from
Jan 3, 2022

Conversation

IamPete1
Copy link
Member

This adds magfit support for the new param naming scheme in ArduPilot/ardupilot#19490

Tested with current AP and built from that branch.

tridge
tridge previously requested changes Dec 27, 2021
View reviewed changes
tools/magfit_WMM.py Show resolved Hide resolved
@IamPete1 IamPete1 dismissed tridge’s stale review January 1, 2022 00:09

Still works with old logs

@IamPete1 IamPete1 requested a review from tridge January 1, 2022 00:09
@IamPete1
Copy link
Member Author

IamPete1 commented Jan 1, 2022

There must be some clever stuff in the recv_match function to handle the instance logging because this script does not deal with it. Hence this change did not break it.

@tridge tridge merged commit 43dae79 into ArduPilot:master Jan 3, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge Awaiting requested review from tridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IamPete1 @tridge @CraigElder