XSD: MAV_CMD missionOnly attribute #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm auto-adding documentation for MAV_CMDs that would be better if sent in COMMAND_INT rather than COMMAND_LONG, based on the
hasLocationandisDestinationproperties (in mavlink/mavlink#1992).There are some MAV_CMDs (specifically in fence) that have position, but make no sense in a command. This adds the
missionOnlyattribute that can be applied to the very small subset of mission items to exclude them from getting that note.Note that at this point haven't found a use case for
commandOnly- most commands might in theory be used in missions, though for many it is a bit unlikely. I guess we might add this to indicate those commands that really only intended for commands but if desired would address in a separate PR.