mavlogdump: show clear error message when mat_file arg is missing #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Mar 13, 2024
shancock884
force-pushed
the
mat_file-arg-missing-msg
branch
from
237744a
to
7e2e2c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use mavlogdump to generate a .mat file from a .bin file, and forgot to specify the --mat_file argument. I found the exception thrown by the call to scipy.io.savemat was not very clear as to my mistake.
This PR adds a check before processing the input file that the required argument is specified, and gives the user a clearer message as follows:
mat_file argument must be specified when mat format is selected