Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): datasets page #3172

Merged
merged 5 commits into from
May 15, 2024
Merged

feat(datasets): datasets page #3172

merged 5 commits into from
May 15, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented May 11, 2024

resolves #3165
resolves #3166

Screenshot 2024-05-15 at 4 26 43 PM

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mikeldking mikeldking marked this pull request as ready for review May 15, 2024 22:29
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 15, 2024
Comment on lines +12 to +14
"@codemirror/autocomplete": "6.12.0",
"@codemirror/lang-json": "6.0.1",
"@codemirror/lang-python": "6.1.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did these need to be pinned exactly in this way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah for now

@mikeldking mikeldking merged commit ff90aad into datasets May 15, 2024
6 checks passed
@mikeldking mikeldking deleted the 3165-datasets-page branch May 15, 2024 23:13
axiomofjoy pushed a commit that referenced this pull request May 17, 2024
* WIP

* WIP

* fix

* remove console log

* remove console log
mikeldking added a commit that referenced this pull request May 21, 2024
* WIP

* WIP

* fix

* remove console log

* remove console log
mikeldking added a commit that referenced this pull request Jun 1, 2024
* WIP

* WIP

* fix

* remove console log

* remove console log
mikeldking added a commit that referenced this pull request Jun 6, 2024
* WIP

* WIP

* fix

* remove console log

* remove console log
mikeldking added a commit that referenced this pull request Jun 11, 2024
* WIP

* WIP

* fix

* remove console log

* remove console log
mikeldking added a commit that referenced this pull request Jun 17, 2024
* WIP

* WIP

* fix

* remove console log

* remove console log
mikeldking added a commit that referenced this pull request Jun 29, 2024
* WIP

* WIP

* fix

* remove console log

* remove console log
mikeldking added a commit that referenced this pull request Jul 2, 2024
* WIP

* WIP

* fix

* remove console log

* remove console log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants