fix: update component colors #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mikeldking
reviewed
Mar 14, 2024
src/label/Label.tsx
Outdated
Comment on lines
74
to
95
| color: ${theme.labelColors.blue}; | ||
| border: 1px solid ${theme.labelColors.blue}; | ||
| color: var(--ac-global-color-blue-900); | ||
| border: 1px solid var(--ac-global-color-blue-900); | ||
| } | ||
| &.ac-label--orange { | ||
| color: ${theme.labelColors.orange}; | ||
| border: 1px solid ${theme.labelColors.orange}; | ||
| color: var(--ac-global-color-orange-900); | ||
| border: 1px solid var(--ac-global-color-orange-900); | ||
| } | ||
| &.ac-label--green { | ||
| color: ${theme.labelColors.green}; | ||
| border: 1px solid ${theme.labelColors.green}; | ||
| color: var(--ac-global-color-green-900); | ||
| border: 1px solid var(--ac-global-color-green-900); | ||
| } | ||
| &.ac-label--red { | ||
| color: ${theme.labelColors.red}; | ||
| border: 1px solid ${theme.labelColors.red}; | ||
| color: var(--ac-global-color-red-900); | ||
| border: 1px solid var(--ac-global-color-red-900); | ||
| } | ||
| &.ac-label--purple { | ||
| color: ${theme.labelColors.purple}; | ||
| border: 1px solid ${theme.labelColors.purple}; | ||
| color: var(--ac-global-color-purple-900); | ||
| border: 1px solid var(--ac-global-color-purple-900); | ||
| } | ||
| &.ac-label--gray { | ||
| color: ${theme.labelColors.gray}; | ||
| border: 1px solid ${theme.labelColors.gray}; |
There was a problem hiding this comment.
Let's leave these alone and just deprecate them entirely later
There was a problem hiding this comment.
yep - makes sense. reverted
mikeldking
reviewed
Mar 14, 2024
src/textfield/TextArea.tsx
Outdated
| @@ -51,7 +51,7 @@ function TextArea(props: TextAreaProps, ref: RefObject<TextFieldRef>) { | |||
| // overflow: hidden in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1787062 | |||
| const isFirefox = 'MozAppearance' in input.style; | |||
| if (!isFirefox) { | |||
| input.style.overflow = 'hidden'; | |||
There was a problem hiding this comment.
I'm not sure we should do this. See comment above
mikeldking
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes a few component colors to transition better in light/dark mode