Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Possible] Broadcast fee too low - both "accepted" and "invalid" #1937

Closed
alexbarnsley opened this issue Jan 3, 2019 · 3 comments
Closed
Assignees

Comments

@alexbarnsley
Copy link
Member

Describe the bug
I'm not sure if this is an issue or not after speaking to @faustbrian. If the minBroadcastFee is set high, it's possible for the node receiving the transaction to accept it. It's also possible for the transaction to be invalid because it's not able to broadcast. The question is, should it be both accepted and invalid at the same time?

@faustbrian
Copy link
Contributor

We should probably change the logic at https://github.com/ArkEcosystem/core/blob/develop/packages/core-transaction-pool/src/guard.ts#L124-L135 and only return an error for a transaction if both fail.

@supaiku0 thoughts?

@faustbrian
Copy link
Contributor

I think we should also use 2 distinct error codes rather then simply ERR_LOW_FEE for both scenarios. The client won't be able to know what failed unless he checks the accompanying message.

@zillionn
Copy link
Contributor

zillionn commented Jan 3, 2019

IMO if accepted OR broadcasted shouldn't be invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants