fix(core-transaction-pool-mem): sort transactions by numerical fee value #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustbrian
suggested changes
Nov 5, 2018
| return -1 | ||
| } | ||
| if (a.transaction.fee < b.transaction.fee) { | ||
| if (+bignumify(a.transaction.fee).toFixed() < +bignumify(b.transaction.fee).toFixed()) { |
There was a problem hiding this comment.
| @@ -218,10 +219,10 @@ class Mem { | |||
| getTransactionsOrderedByFee () { | |||
| if (!this.allIsSorted) { | |||
| this.all.sort(function (a, b) { | |||
| if (a.transaction.fee > b.transaction.fee) { | |||
| if (+bignumify(a.transaction.fee).toFixed() > +bignumify(b.transaction.fee).toFixed()) { | |||
There was a problem hiding this comment.
ghost
assigned
faustbrian
approved these changes
Nov 5, 2018
faustbrian
changed the title
faustbrian
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1288 +/- ##
===========================================
- Coverage 77.58% 77.55% -0.03%
===========================================
Files 397 397
Lines 6925 6925
Branches 952 952
===========================================
- Hits 5373 5371 -2
- Misses 1364 1366 +2
Partials 188 188
Continue to review full report at Codecov.
|
|
I resolved the test issues again this time. Next time run the tests locally before you send a PR and make sure they pass. |
|
@faustbrian Sorry, I just saw the bug but it was 2:20 AM here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In getTransactionsOrderedByFee()
a.transaction.feeandb.transaction.feeare BigNumber objects not numbers and the comparison fails.Checklist