Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-tester-cli): init command #1415

Merged
merged 3 commits into from
Nov 18, 2018

Conversation

whitehat
Copy link
Contributor

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #1415 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1415      +/-   ##
===========================================
- Coverage    73.32%   73.28%   -0.04%     
===========================================
  Files          420      420              
  Lines         7540     7540              
  Branches       996      996              
===========================================
- Hits          5529     5526       -3     
- Misses        1780     1783       +3     
  Partials       231      231
Impacted Files Coverage Δ
packages/core-forger/lib/manager.js 71.56% <0%> (-1.97%) ⬇️
packages/core-blockchain/lib/state-machine.js 43.52% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad13e76...7d9539f. Read the comment docs.

@faustbrian faustbrian changed the title Add Init Command Test test(core-tester-cli): init command Nov 17, 2018
@faustbrian
Copy link
Contributor

There are a few conflicts, also please take a look at https://docs.ark.io/guidebook/contribution-guidelines/git-commit-guidelines.html for future PRs.

@faustbrian
Copy link
Contributor

Again conflicts.

@whitehat
Copy link
Contributor Author

Yes I Waiting For Other Requests To Merge. Resolved Now

@ghost ghost assigned faustbrian Nov 18, 2018
@ghost ghost added the review label Nov 18, 2018
@faustbrian faustbrian merged commit 59d63d9 into ArkEcosystem:develop Nov 18, 2018
@ghost ghost removed the review label Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants