Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-database-postgres): set last block of all delegates during SPV #1919

Merged
merged 1 commit into from Dec 30, 2018
Merged

fix(core-database-postgres): set last block of all delegates during SPV #1919

merged 1 commit into from Dec 30, 2018

Conversation

dated
Copy link
Contributor

@dated dated commented Dec 29, 2018 •
edited

Proposed changes

Instead of fetching only the last 51 blocks during the SPV this PR fetches the last block of all delegates, fixing #1847.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@dated dated changed the title fix(core-database-postgres): populate last block of all delegates during SPV fix(core-database-postgres): set last block of all delegates during SPV Dec 29, 2018
@faustbrian faustbrian self-requested a review December 30, 2018 04:56
@faustbrian faustbrian merged commit 6967e5b into ArkEcosystem:develop Dec 30, 2018
@dated dated deleted the last-blocks branch December 30, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dated @faustbrian