chore: better database detection in install script #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustbrian
approved these changes
Jan 29, 2019
vasild
approved these changes
Jan 29, 2019
Codecov Report
@@ Coverage Diff @@
## develop #2031 +/- ##
=======================================
Coverage 73.3% 73.3%
=======================================
Files 373 373
Lines 8255 8255
Branches 1177 1197 +20
=======================================
Hits 6051 6051
+ Misses 2174 2172 -2
- Partials 30 32 +2
Continue to review full report at Codecov.
|
vasild
added a commit
that referenced
this pull request
Jan 30, 2019
…peer-state * ArkEcosystem/core/develop: fix(core-snapshots): use correct paths and add migration (#2033) fix(core-api): return fixed states for the v1 and v2 API peer lists (#2027) chore: replace all ARK occurrences with CORE during the upgrade chore: better database detection in install script (#2031)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Better handling of existing DB detection.
Types of changes
Checklist