Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POSTPONED] refactor: mark methods as protected and private #2035

Closed
wants to merge 4 commits into from
Closed

[POSTPONED] refactor: mark methods as protected and private #2035

wants to merge 4 commits into from

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Gets rid of the prefixes we used in the JavaScript code since there is no concept of method visibility.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from spkjp January 30, 2019 10:50
@faustbrian faustbrian changed the title refactor: mark methods as protected and private [POSTPONED] refactor: mark methods as protected and private Jan 30, 2019
@faustbrian faustbrian closed this Feb 1, 2019
@ghost ghost removed Status: Needs Review labels Feb 1, 2019
@faustbrian faustbrian deleted the refactor/visibility branch February 1, 2019 11:41
@faustbrian faustbrian removed the request for review from spkjp February 1, 2019 11:41
@ghost ghost mentioned this pull request Feb 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faustbrian @air1one