Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): wallet search #2926

Merged
merged 12 commits into from
Sep 17, 2019
Merged

fix(core-api): wallet search #2926

merged 12 commits into from
Sep 17, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Sep 14, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

codecov-io commented Sep 14, 2019

Codecov Report

Merging #2926 into develop will decrease coverage by <.01%.
The diff coverage is 67.74%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2926      +/-   ##
===========================================
- Coverage    68.12%   68.12%   -0.01%     
===========================================
  Files          406      406              
  Lines         9795     9819      +24     
  Branches       510      469      -41     
===========================================
+ Hits          6673     6689      +16     
- Misses        3079     3091      +12     
+ Partials        43       39       -4
Impacted Files Coverage Δ
...transactions/src/handlers/delegate-registration.ts 43.63% <ø> (ø) ⬆️
packages/core-api/src/handlers/delegates/schema.ts 100% <ø> (ø) ⬆️
...ges/core-api/src/handlers/delegates/transformer.ts 85.71% <ø> (ø) ⬆️
...-transactions/src/handlers/delegate-resignation.ts 68.75% <0%> (-4.59%) ⬇️
.../core-api/src/handlers/transactions/transformer.ts 100% <100%> (ø) ⬆️
...kages/core-api/src/handlers/wallets/transformer.ts 100% <100%> (ø) ⬆️
...se/src/repositories/wallets-business-repository.ts 96.29% <100%> (+0.29%) ⬆️
packages/core-state/src/wallets/wallet-manager.ts 89.17% <100%> (+0.34%) ⬆️
.../src/repositories/delegates-business-repository.ts 73.17% <44.44%> (-6.25%) ⬇️
...re-database/src/repositories/utils/sort-entries.ts 87.5% <71.42%> (-12.5%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c800e8...df721ee. Read the comment docs.

@faustbrian faustbrian merged commit 6a88e9f into develop Sep 17, 2019
@ghost ghost deleted the fix/core-api/wallet-search branch September 17, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants